Skip to content

Conversation

GideonBature
Copy link

@GideonBature GideonBature commented Oct 7, 2025

Description

Renames cancel_tx() to unreserve_change_address() to better reflect its current functionality, which only frees up the change address and does not yet handle UTXO reservation.

Changelog notice

Changed

  • Renamed cancel_tx() to unreserve_change_address() for clarity

Closes #212

@luisschwab luisschwab moved this to In Progress in BDK Wallet Oct 7, 2025
@luisschwab luisschwab moved this from In Progress to Needs Review in BDK Wallet Oct 7, 2025
@GideonBature GideonBature marked this pull request as draft October 7, 2025 07:07
@GideonBature GideonBature force-pushed the freeing-reserved-utxos branch from e5b8d34 to 3f7ff2d Compare October 7, 2025 19:07
@GideonBature GideonBature marked this pull request as ready for review October 7, 2025 19:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18323393969

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.813%

Totals Coverage Status
Change from base Build 18318022693: 0.0%
Covered Lines: 6908
Relevant Lines: 8145

💛 - Coveralls

@GideonBature GideonBature changed the title Implement freeing up reserved utxos and cancel_tx Rename cancel_tx to unreserve_change_address Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

Rename cancel_tx to unreserve_change_address
2 participants